Messages in this thread | | | From | Linus Torvalds <> | Date | Fri, 16 Mar 2012 22:51:32 -0700 | Subject | Re: [PATCH] firmware loader: don't cancel _nowait requests when helper is not yet available |
| |
On Fri, Mar 16, 2012 at 7:47 PM, Stephen Boyd <sboyd@codeaurora.org> wrote: > - if (WARN_ON(usermodehelper_is_disabled())) { > + if (is_sleep_task()) { > dev_err(device, "firmware: %s will not be loaded\n", name);
Stop these idiotic games already!
It's very simple: you cannot load firmware while the system is not readt. Your moronic "let's change the test to something else" is entirely and utterly misguided and totally misses the point.
It's not about sleeping, and it's not about anything even *remotely* about that. Stop the idiocy already.
How hard is it to understand? How many times do people have to tell you?
That warning is very much valid during bootup, and that warning has been *seen* during bootup. For example, try to compile in most wireless drivers as non-modular, and that warning *has* to trigger.
Rafael, please consider everything along these *IDIOTIC* lines completely NAK'ed. In fact, until Stephen starts showing any sign of understanding that it's not about just some random small detail, just ignore anything and everything from him.
Stephen, you've been told multiple times that that WARN_ON() is correct. Until you understand that, just stop sending these entirely random patches that change it to something completely wrong.
How hard can it be to understand that you cannot and must not load firmware when the system isn't up-and-running.
And *dammit*, the fact that you send these kinds of completely nonsensical patches that seem to think that "up-and-running" is just about suspend (and not bootup, for example), all you are showing is that you don't understand the problem. Stop, think, and read the emails that have been in this thread and that have explained how it *could* be solved.
Until you do that, any patch you send is just worthless. Really.
Linus
Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |