Messages in this thread Patch in this message | | | From | Namhyung Kim <> | Subject | [PATCH v2 5/5] perf report: Treat an argument as a symbol filter | Date | Fri, 16 Mar 2012 17:50:55 +0900 |
| |
As Ingo requested, it'd be better off treating first (and the only) argument as a symbol filter, so that user doesn't need to input the symbol on the dialog window on TUI.
Signed-off-by: Namhyung Kim <namhyung.kim@lge.com> --- tools/perf/builtin-report.c | 15 ++++++++++----- 1 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index 80fb90741b64..c00545806bb7 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c @@ -715,11 +715,16 @@ int cmd_report(int argc, const char **argv, const char *prefix __used) } else symbol_conf.exclude_other = false; - /* - * Any (unrecognized) arguments left? - */ - if (argc) - usage_with_options(report_usage, options); + if (argc) { + /* + * Special case: if there's an argument left then assume that + * it's a symbol filter: + */ + if (argc > 1) + usage_with_options(report_usage, options); + + report.symbol_filter_str = argv[0]; + } sort_entry__setup_elide(&sort_comm, symbol_conf.comm_list, "comm", stdout); -- 1.7.9
| |