Messages in this thread | | | Date | Fri, 16 Mar 2012 20:41:35 -0700 | From | Randy Dunlap <> | Subject | Re: + drivers-platform-x86-samsung-laptopc-fix-build.patch added to -mm tree |
| |
On 03/16/2012 03:53 PM, akpm@linux-foundation.org wrote:
> The patch titled > Subject: drivers/platform/x86/samsung-laptop.c: fix build > has been added to the -mm tree. Its filename is > drivers-platform-x86-samsung-laptopc-fix-build.patch >
See https://lkml.org/lkml/2012/3/14/25 and https://lkml.org/lkml/2012/3/14/27 from David Reintjes.
> > ------------------------------------------------------ > From: Andrew Morton <akpm@linux-foundation.org> > Subject: drivers/platform/x86/samsung-laptop.c: fix build > > gcc-4.4.4: > > drivers/platform/x86/samsung-laptop.c: In function 'sabi_set_commandb': > drivers/platform/x86/samsung-laptop.c:433: error: unknown field 'd0' specified in initializer > drivers/platform/x86/samsung-laptop.c:433: warning: missing braces around initializer > drivers/platform/x86/samsung-laptop.c:433: warning: (near initialization for 'in.<anonymous>') > drivers/platform/x86/samsung-laptop.c:433: error: unknown field 'd1' specified in initializer > drivers/platform/x86/samsung-laptop.c:433: warning: excess elements in struct initializer > drivers/platform/x86/samsung-laptop.c:433: warning: (near initialization for 'in') > drivers/platform/x86/samsung-laptop.c:433: error: unknown field 'd2' specified in initializer > drivers/platform/x86/samsung-laptop.c:433: warning: excess elements in struct initializer > drivers/platform/x86/samsung-laptop.c:433: warning: (near initialization for 'in') > drivers/platform/x86/samsung-laptop.c:433: error: unknown field 'd3' specified in initializer > drivers/platform/x86/samsung-laptop.c:433: warning: excess elements in struct initializer > drivers/platform/x86/samsung-laptop.c:433: warning: (near initialization for 'in') > drivers/platform/x86/samsung-laptop.c: At top level: > drivers/platform/x86/samsung-laptop.c:1108: warning: initialization from incompatible pointer type > > Cc: Corentin Chary <corentincj@iksaif.net> > Cc: Matthew Garrett <mjg@redhat.com> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> > --- > > drivers/platform/x86/samsung-laptop.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -puN drivers/platform/x86/samsung-laptop.c~drivers-platform-x86-samsung-laptopc-fix-build drivers/platform/x86/samsung-laptop.c > --- a/drivers/platform/x86/samsung-laptop.c~drivers-platform-x86-samsung-laptopc-fix-build > +++ a/drivers/platform/x86/samsung-laptop.c > @@ -430,7 +430,7 @@ exit: > static int sabi_set_commandb(struct samsung_laptop *samsung, > u16 command, u8 data) > { > - struct sabi_data in = { .d0 = 0, .d1 = 0, .d2 = 0, .d3 = 0 }; > + struct sabi_data in = { { { .d0 = 0, .d1 = 0, .d2 = 0, .d3 = 0 } } }; > > in.data[0] = data; > return sabi_command(samsung, command, &in, NULL); > _ > Subject: Subject: drivers/platform/x86/samsung-laptop.c: fix build
--
~Randy
| |