lkml.org 
[lkml]   [2012]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 01/10] cgroup: move cgroup_clear_directory() call out of cgroup_populate_dir()
    Date
    cgroup_populate_dir() currently clears all files and then repopulate
    the directory; however, the clearing part is only useful when it's
    called from cgroup_remount(). Relocate the invocation to
    cgroup_remount().

    This is to prepare for further cgroup file handling updates.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    ---
    kernel/cgroup.c | 6 ++----
    1 files changed, 2 insertions(+), 4 deletions(-)

    diff --git a/kernel/cgroup.c b/kernel/cgroup.c
    index deeab87..2e2f93b 100644
    --- a/kernel/cgroup.c
    +++ b/kernel/cgroup.c
    @@ -1313,7 +1313,8 @@ static int cgroup_remount(struct super_block *sb, int *flags, char *data)
    goto out_unlock;
    }

    - /* (re)populate subsystem files */
    + /* clear out any existing files and repopulate subsystem files */
    + cgroup_clear_directory(cgrp->dentry);
    cgroup_populate_dir(cgrp);

    if (opts.release_agent)
    @@ -3648,9 +3649,6 @@ static int cgroup_populate_dir(struct cgroup *cgrp)
    int err;
    struct cgroup_subsys *ss;

    - /* First clear out any existing files */
    - cgroup_clear_directory(cgrp->dentry);
    -
    err = cgroup_add_files(cgrp, NULL, files, ARRAY_SIZE(files));
    if (err < 0)
    return err;
    --
    1.7.7.3


    \
     
     \ /
      Last update: 2012-03-17 01:05    [W:0.022 / U:0.132 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site