[lkml]   [2012]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[ 07/41] [media] omap3isp: ccdc: Fix crash in HS/VS interrupt handler
    3.2-stable review patch.  If anyone has any objections, please let me know.


    From: Laurent Pinchart <>

    commit bd0f2e6da7ea9e225cb2dbd3229e25584b0e9538 upstream.

    The HS/VS interrupt handler needs to access the pipeline object. It
    erronously tries to get it from the CCDC output video node, which isn't
    necessarily included in the pipeline. This leads to a NULL pointer

    Fix the bug by getting the pipeline object from the CCDC subdev entity.

    Reported-by: Gary Thomas <>
    Signed-off-by: Laurent Pinchart <>
    Acked-by: Sakari Ailus <>
    Signed-off-by: Mauro Carvalho Chehab <>
    Signed-off-by: Greg Kroah-Hartman <>

    drivers/media/video/omap3isp/ispccdc.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/drivers/media/video/omap3isp/ispccdc.c
    +++ b/drivers/media/video/omap3isp/ispccdc.c
    @@ -1406,8 +1406,7 @@ static int __ccdc_handle_stopping(struct

    static void ccdc_hs_vs_isr(struct isp_ccdc_device *ccdc)
    - struct isp_pipeline *pipe =
    - to_isp_pipeline(&ccdc->;
    + struct isp_pipeline *pipe = to_isp_pipeline(&ccdc->subdev.entity);
    struct video_device *vdev = ccdc->subdev.devnode;
    struct v4l2_event event;

     \ /
      Last update: 2012-03-17 00:51    [W:0.020 / U:41.288 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site