lkml.org 
[lkml]   [2012]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] [media] staging: Return -EINTR in s2250_probe() if fails to get lock.
    Date
    Am Freitag, 16. März 2012, 17:23:58 schrieb santosh nayak:
    > From: Santosh Nayak <santoshprasadnayak@gmail.com>
    >
    > In s2250_probe(), If locking attempt is interrupted by a signal then
    > it should return -EINTR after unregistering audio device and making free
    > the allocated memory.
    >
    > At present, if locking is interrupted by signal it will display message
    > "initialized successfully" and return success. This is wrong.

    Indeed there's a lot wrong here. The idea of having an interruptible
    sleep in probe() is arcane. You need a very, very, very good reason for that.
    The sane fix is using an uninterruptable sleep here.

    Second, while you are at it, fix the error case for no initialization
    due to a failing kmalloc(). You need to return -ENOMEM.

    Regards
    Oliver
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-03-16 17:35    [W:0.030 / U:120.992 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site