lkml.org 
[lkml]   [2012]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRE: [PATCH] Fix the race between smp_call_function and CPU booting
    From
    Date
    On Fri, 2012-03-16 at 06:24 +0000, Liu, Chuansheng wrote:

    > Based on your patch, I did a little modification, how do you think of that?

    > --- a/kernel/cpu.c
    > +++ b/kernel/cpu.c
    > @@ -640,8 +640,10 @@ void set_cpu_present(unsigned int cpu, bool present)
    >
    > void set_cpu_online(unsigned int cpu, bool online)
    > {
    > - if (online)
    > + if (online) {
    > cpumask_set_cpu(cpu, to_cpumask(cpu_online_bits));
    > + cpumask_set_cpu(cpu, to_cpumask(cpu_active_bits));
    > + }
    > else
    > cpumask_clear_cpu(cpu, to_cpumask(cpu_online_bits));
    > }

    I'm thinking this lacks rationale. What was wrong, Why does this fix it.
    If you can't answer that stop tinkering and start thinking.


    \
     
     \ /
      Last update: 2012-03-16 10:53    [W:0.020 / U:120.200 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site