lkml.org 
[lkml]   [2012]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:timers/core] ntp: Fix integer overflow when setting time
On Thu, 15 Mar 2012, H. Peter Anvin wrote:

> On 03/15/2012 02:53 PM, tip-bot for Sasha Levin wrote:
> > Commit-ID: a078c6d0e6288fad6d83fb6d5edd91ddb7b6ab33
> > Gitweb: http://git.kernel.org/tip/a078c6d0e6288fad6d83fb6d5edd91ddb7b6ab33
> > Author: Sasha Levin <levinsasha928@gmail.com>
> > AuthorDate: Thu, 15 Mar 2012 12:36:14 -0400
> > Committer: Thomas Gleixner <tglx@linutronix.de>
> > CommitDate: Thu, 15 Mar 2012 21:41:34 +0100
> >
> > ntp: Fix integer overflow when setting time
> >
> > 'long secs' is passed as divisor to div_s64, which accepts a 32bit
> > divisor. On 64bit machines that value is trimmed back from 8 bytes
> > back to 4, causing a divide by zero when the number is bigger than
> > (1 << 32) - 1 and all 32 lower bits are 0.
> >
> > Use div64_long() instead.
> >
>
> Perhaps we should use the same kind of multiply-and-shift tricks we're
> doing for jiffies conversion? If nothing else it ought to perform better.

It's not a hotpath where performance matters, but divide by zero does :)


\
 
 \ /
  Last update: 2012-03-16 10:51    [W:0.045 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site