Messages in this thread | | | Subject | Re: [PATCH] scsi: qla2xxx: fix section mismatch in linux-next | From | "Nicholas A. Bellinger" <> | Date | Thu, 15 Mar 2012 16:31:16 -0700 |
| |
On Thu, 2012-03-15 at 14:40 -0700, Gerard Snitselaar wrote: > qla_tgt_exit() is annotated __exit , but called in > qla2x00_module_init(). > > Signed-off-by: Gerard Snitselaar <dev@snitselaar.org> > --- > drivers/scsi/qla2xxx/qla_target.c | 2 +- > drivers/scsi/qla2xxx/qla_target.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >
Hi Gerard,
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c > index 6d6f1cf..699d16e 100644 > --- a/drivers/scsi/qla2xxx/qla_target.c > +++ b/drivers/scsi/qla2xxx/qla_target.c > @@ -4730,7 +4730,7 @@ out: > return ret; > } > > -void __exit qla_tgt_exit(void) > +void qla_tgt_exit(void) > { > destroy_workqueue(qla_tgt_wq); > mempool_destroy(qla_tgt_mgmt_cmd_mempool); > diff --git a/drivers/scsi/qla2xxx/qla_target.h b/drivers/scsi/qla2xxx/qla_target.h > index db6b399..b9d0aa1 100644 > --- a/drivers/scsi/qla2xxx/qla_target.h > +++ b/drivers/scsi/qla2xxx/qla_target.h > @@ -934,7 +934,7 @@ extern void qla_tgt_fc_port_deleted(struct scsi_qla_host *, fc_port_t *); > extern void qla_tgt_set_mode(struct scsi_qla_host *ha); > extern void qla_tgt_clear_mode(struct scsi_qla_host *ha); > extern int __init qla_tgt_init(void); > -extern void __exit qla_tgt_exit(void); > +extern void qla_tgt_exit(void); > > static inline bool qla_tgt_mode_enabled(struct scsi_qla_host *ha) > {
This looks fine. Applied to lio-core, and will get this fixed up in target-pending/for-next-merge shortly.
Thanks for your patch!
--nab
| |