Messages in this thread | | | Subject | RE: [PATCH] mpt2sas: Corrected the constant in comparison to a hexadecimal. | From | James Bottomley <> | Date | Thu, 15 Mar 2012 08:56:46 +0000 |
| |
On Wed, 2012-03-14 at 23:36 +0000, Nanjappa, Sathisha (MCXS, Cupertino) wrote: > > > > On Tue, 2012-03-13 at 11:59 -0700, Sathisha Nanjappa wrote: > > > Bugzilla 42142 - mpt2sas: Number specified in wrong base > > > https://bugzilla.kernel.org/show_bug.cgi?id=42142 > > > > From: James Bottomley > > Sent: Wednesday, March 14, 2012 1:34 AM > > Do you have a better description ... like what is the user > > visible effect of correcting the constant? > > > > Does this look better: > > "This fix ensures that the IOP_LOGINFO_CODE_TASK_TERMINATED > messages do not clutter the sas_log_info messages."
Much better, thanks. The whole point of a commit message is to explain what you're doing and why you're doing it. Just translating C to english isn't useful because everyone who looks a kernel patches can read C.
James
| |