lkml.org 
[lkml]   [2012]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH] mpt2sas: Corrected the constant in comparison to a hexadecimal.
From
Date
On Wed, 2012-03-14 at 23:36 +0000, Nanjappa, Sathisha (MCXS, Cupertino)
wrote:
> >
> > On Tue, 2012-03-13 at 11:59 -0700, Sathisha Nanjappa wrote:
> > > Bugzilla 42142 - mpt2sas: Number specified in wrong base
> > > https://bugzilla.kernel.org/show_bug.cgi?id=42142
> >
> > From: James Bottomley
> > Sent: Wednesday, March 14, 2012 1:34 AM
> > Do you have a better description ... like what is the user
> > visible effect of correcting the constant?
> >
>
> Does this look better:
>
> "This fix ensures that the IOP_LOGINFO_CODE_TASK_TERMINATED
> messages do not clutter the sas_log_info messages."

Much better, thanks. The whole point of a commit message is to explain
what you're doing and why you're doing it. Just translating C to
english isn't useful because everyone who looks a kernel patches can
read C.

James




\
 
 \ /
  Last update: 2012-03-15 09:59    [W:0.312 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site