lkml.org 
[lkml]   [2012]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH] Fix c6x's entry.S
From
Date
On Thu, 2012-03-15 at 17:52 +0000, David Howells wrote:
> The ENDPROC() on sys_fadvise64_c6x() in arch/c6x/kernel/entry.S needs to be
> transposed with the preceding #endif so that it's in the same conditional
> block as the matching ENTRY() macro.
>
> Without this, I see:
>
> /tmp/ccGZBaPT.s: Assembler messages:
> /tmp/ccGZBaPT.s: Error: .size expression for sys_fadvise64_c6x does not evaluate to a constant
>
> Signed-off-by: David Howells <dhowells@redhat.com>
> ---
>
> arch/c6x/kernel/entry.S | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/c6x/kernel/entry.S b/arch/c6x/kernel/entry.S
> index 3e977cc..91b2e79 100644
> --- a/arch/c6x/kernel/entry.S
> +++ b/arch/c6x/kernel/entry.S
> @@ -741,8 +741,8 @@ ENTRY(sys_fadvise64_c6x)
> #endif
> MV .D1X B6,A6
> MV .D2X A8,B6
> -#endif
> ENDPROC(sys_fadvise64_c6x)
> +#endif

Thanks! Actually, I'll delete sys_fadvise64_c6x altogether. It is
leftover cruft since we no longer support __ARCH_WANT_SYSCALL_OFF_T.

As an aside, the build tools I'm using didn't catch that. I definitely
need to upgrade...

--Mark



\
 
 \ /
  Last update: 2012-03-15 19:37    [W:0.133 / U:1.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site