Messages in this thread Patch in this message | | | Subject | Re: [PATCH] Fix c6x's entry.S | From | Mark Salter <> | Date | Thu, 15 Mar 2012 14:34:00 -0400 |
| |
On Thu, 2012-03-15 at 17:52 +0000, David Howells wrote: > The ENDPROC() on sys_fadvise64_c6x() in arch/c6x/kernel/entry.S needs to be > transposed with the preceding #endif so that it's in the same conditional > block as the matching ENTRY() macro. > > Without this, I see: > > /tmp/ccGZBaPT.s: Assembler messages: > /tmp/ccGZBaPT.s: Error: .size expression for sys_fadvise64_c6x does not evaluate to a constant > > Signed-off-by: David Howells <dhowells@redhat.com> > --- > > arch/c6x/kernel/entry.S | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/c6x/kernel/entry.S b/arch/c6x/kernel/entry.S > index 3e977cc..91b2e79 100644 > --- a/arch/c6x/kernel/entry.S > +++ b/arch/c6x/kernel/entry.S > @@ -741,8 +741,8 @@ ENTRY(sys_fadvise64_c6x) > #endif > MV .D1X B6,A6 > MV .D2X A8,B6 > -#endif > ENDPROC(sys_fadvise64_c6x) > +#endif
Thanks! Actually, I'll delete sys_fadvise64_c6x altogether. It is leftover cruft since we no longer support __ARCH_WANT_SYSCALL_OFF_T.
As an aside, the build tools I'm using didn't catch that. I definitely need to upgrade...
--Mark
| |