lkml.org 
[lkml]   [2012]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] mpt2sas: Corrected the constant in comparison to a hexadecimal.
Date
> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-
> owner@vger.kernel.org] On Behalf Of James Bottomley
> Sent: Thursday, March 15, 2012 1:57 AM
>
> On Wed, 2012-03-14 at 23:36 +0000, Nanjappa, Sathisha (MCXS, Cupertino)
> wrote:
> > >
> > > On Tue, 2012-03-13 at 11:59 -0700, Sathisha Nanjappa wrote:
> > > > Bugzilla 42142 - mpt2sas: Number specified in wrong base
> > > > https://bugzilla.kernel.org/show_bug.cgi?id=42142
> > >
> > > From: James Bottomley
> > > Sent: Wednesday, March 14, 2012 1:34 AM
> > > Do you have a better description ... like what is the user
> > > visible effect of correcting the constant?
> > >
> >
> > Does this look better:
> >
> > "This fix ensures that the IOP_LOGINFO_CODE_TASK_TERMINATED
> > messages do not clutter the sas_log_info messages."
>
> Much better, thanks. The whole point of a commit message is to explain
> what you're doing and why you're doing it. Just translating C to
> english isn't useful because everyone who looks a kernel patches can
> read C.
>

Thanks for clarifying. I'll keep that in mind during my future submittal requests.

FYI, I've received ack's from:

Acked-by: "Nandigama, Nagalakshmi" <Nagalakshmi.Nandigama@lsi.com>
Acked-by: "Chris Dunlop" <chris@onthe.net.au>
-Satish.

\
 
 \ /
  Last update: 2012-03-15 18:57    [from the cache]
©2003-2011 Jasper Spaans