Messages in this thread | | | From | Bjorn Helgaas <> | Date | Thu, 15 Mar 2012 11:34:46 -0600 | Subject | Re: [PATCH v2 22/37] PCI, acpiphp: remove hot-add support of pci host bridge |
| |
On Mon, Mar 12, 2012 at 11:58 PM, Yinghai Lu <yinghai@kernel.org> wrote: > On Mon, Mar 12, 2012 at 8:14 PM, Bjorn Helgaas <bhelgaas@google.com> wrote: >> On Sat, Mar 10, 2012 at 12:00 AM, Yinghai Lu <yinghai@kernel.org> wrote: >>> It causes confusing. >> >> "causes confusion." >> >>> We may only need acpi hp for pci host bridge. >>> >>> Split host bridge hot-add support to another file, and keep acpiphp simple. >> >> I think it's a good thing to remove host bridge hotplug from acpiphp; >> thanks for doing that. >> >> However, I think you removed it here, but didn't add it elsewhere >> until a different patch. That means we can't bisect across this. It >> would be better to do the entire move in a single patch. > > do you mean merge patch 22 and 23 together?
Yes, I think so. You should have a single "move," not separate patches that "remove" then "add." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |