lkml.org 
[lkml]   [2012]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/6] Add a per-dimm structure
Em 14-03-2012 20:32, Greg KH escreveu:
> On Wed, Mar 14, 2012 at 07:20:01PM -0300, Mauro Carvalho Chehab wrote:
>>> Easy rule to remember, never mix "raw" kobjects and 'struct device',
>>> which is what you would be doing here, right? We can handle many
>>> hundreds of thousands of files and devices in a single directory, no
>>> problem.
>>
>> No. They're all generated with raw kobjects, using kobject_init_and_add() or
>> sysfs_create_file() calls.
>
> Ick, no.
>
> Please, never use "raw" kobjects. Why doesn't 'struct device' work for
> you properly here? You just messed userspace all up in that it can not
> properly account for the parts of sysfs here in the device tree.
>
> Anything below /sys/devices/ should be using 'struct device' unless
> there is a _very_ good reason not to.

The raw kobjects logic is there since the beginning of the edac. I've no
idea why.

I remember a few years ago I tried to create a virtual class in order to
create the EDAC devices, in order to use struct devices, but the sysfs
nodes were created outside /sys/devices/system, breaking the ABI.

Not sure what changed on sysfs since then, but, on the time I looked
on it, I was unable to find an easy way to solve it.

So, I gave up and just kept it as-is.

>
> thanks,
>
> greg k-h



\
 
 \ /
  Last update: 2012-03-15 03:25    [W:0.111 / U:0.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site