Messages in this thread | | | Date | Thu, 15 Mar 2012 01:34:18 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH 1/2] time: x86: Fix race switching from vsyscall to non-vsyscall clock |
| |
On Wed, 14 Mar 2012, John Stultz wrote: > notrace static noinline int do_realtime(struct timespec *ts) > { > unsigned long seq, ns; > + int mode;
Please keep a newline between declarations and code.
> do { > seq = read_seqbegin(>od->lock); > + mode = gtod->clock.vclock_mode; > ts->tv_sec = gtod->wall_time_sec; > ts->tv_nsec = gtod->wall_time_nsec; > ns = vgetns(); > } while (unlikely(read_seqretry(>od->lock, seq))); > + > timespec_add_ns(ts, ns); > - return 0; > + return mode; > } > > notrace static noinline int do_monotonic(struct timespec *ts) > { > unsigned long seq, ns, secs; > + int mode;
etc. etc.
> do {
| |