lkml.org 
[lkml]   [2012]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] time: x86: Fix race switching from vsyscall to non-vsyscall clock
On Wed, 14 Mar 2012, John Stultz wrote:
> notrace static noinline int do_realtime(struct timespec *ts)
> {
> unsigned long seq, ns;
> + int mode;

Please keep a newline between declarations and code.

> do {
> seq = read_seqbegin(&gtod->lock);
> + mode = gtod->clock.vclock_mode;
> ts->tv_sec = gtod->wall_time_sec;
> ts->tv_nsec = gtod->wall_time_nsec;
> ns = vgetns();
> } while (unlikely(read_seqretry(&gtod->lock, seq)));
> +
> timespec_add_ns(ts, ns);
> - return 0;
> + return mode;
> }
>
> notrace static noinline int do_monotonic(struct timespec *ts)
> {
> unsigned long seq, ns, secs;
> + int mode;

etc. etc.

> do {


\
 
 \ /
  Last update: 2012-03-15 01:37    [W:0.133 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site