lkml.org 
[lkml]   [2012]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 03/13] memcg: Uncharge all kmem when deleting a cgroup.

    >>> @@ -3719,6 +3721,8 @@ move_account:
    >>> /* This is for making all *used* pages to be on LRU. */
    >>> lru_add_drain_all();
    >>> drain_all_stock_sync(memcg);
    >>> + if (!free_all)
    >>> + memcg_kmem_move(memcg);
    >>
    >> Any reason we're not moving kmem charges when free_all is set as well?
    >
    > Because the slab moving code expects to be synchronized with
    > allocations (and itself). We can't call it when there are still tasks
    > in the cgroup.

    Ok.

    Please add an explanation about that.
    Oh boy, reading it all now, I started to believe that "free_all" is a
    really poor name =(




    \
     
     \ /
      Last update: 2012-03-14 13:03    [W:0.020 / U:88.244 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site