Messages in this thread | | | From | Linus Torvalds <> | Date | Tue, 13 Mar 2012 18:51:11 -0700 | Subject | Re: [PATCH] firmware loader: don't cancel _nowait requests when helper is not yet available |
| |
On Tue, Mar 13, 2012 at 6:43 PM, Kay Sievers <kay@vrfy.org> wrote: > > usermodehelper_is_disabled() is a flag from kmod which is all about > exec(). That flag should not be used to decide if a firmware request > can be issued by a driver and queued up or not.
Sorry, you're wrong. And Rafael *told* you why you are wrong, and you ignored him and talked about "exec" some more.
So go back and read Rafael's email. The point is, you are focusing too much on the name (which Rafael talked about and said is misleading).
But it's not the name that matters, it's the concept. Loading firmware during the suspend process is broken (read Rafael's email about suggested renaming).
AND IT HAS NOTHING TO DO WITH EXEC. It doesn't matter *how* you load it. You could load it by reading a file directly from disk, AND IT WOULD STILL BE WRONG FOR THE EXACT SAME DAMN REASON.
I outlined that reason too. The filesystem may not be up and running yet.
Get it?
So please, read the emails. People actually *agree* that the name may be a bit misleading, but instead of harping on bogus issues, just read the emails from people like Rafael about it.
So STOP with this idiocy already. It has nothing to do with exec. Seriously. Get that through your head already.
Linus
| |