lkml.org 
[lkml]   [2012]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC] c/r: prctl: Add ability to set new mm_struct::exe_file v3
    On Tue, Mar 13, 2012 at 04:43:37PM +0100, Oleg Nesterov wrote:
    >
    > Matt, is it really possible to hit mm->exe_file = NULL in
    > removed_exe_file_vma ? Unless I missed something, this check just
    > hides the potentional problem, no?
    >
    > IOW, shouldn't it do
    >
    > void removed_exe_file_vma(struct mm_struct *mm)
    > {
    > WARN_ON(!mm->exe_file);
    > WARN_ON(mm->num_exe_file_vmas <= 0);
    >
    > if (!--mm->num_exe_file_vmas) {
    > fput(mm->exe_file);
    > mm->exe_file = NULL;
    > }
    > }
    >
    > ?

    I think you're spot-on about hiding the problem. I'm not sure the
    WARN_ON() would be welcome in the mm's VMA paths though.
    Also, it's a nit but I'd keep the decrement out of the condition like in
    the original.

    Cheers,
    -Matt



    \
     
     \ /
      Last update: 2012-03-14 01:39    [W:0.021 / U:5.484 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site