lkml.org 
[lkml]   [2012]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] firmware loader: don't cancel _nowait requests when helper is not yet available
    On Tue, Mar 13, 2012 at 20:42, Rafael J. Wysocki <rjw@sisk.pl> wrote:
    > On Sunday, March 11, 2012, Kay Sievers wrote:
    >> On Sat, Mar 10, 2012 at 00:36, Greg KH <gregkh@linuxfoundation.org> wrote:

    >> > What does uevent have to do with things here?
    >>
    >> I don't think that the firmware loader should care about the
    >> usermodehelper at all, and that stuff fiddling should just be removed
    >> from the firmware class.
    >
    > It's there to warn people that their drivers do stupid things like
    > loading frimware during system resume, which is guaranteed not to work.
    >
    > IOW, it's there very much on purpose.

    Using the /sbin/hotplug is no case that needs any warning. It' such a
    broken model these days, that firmware loading is the least problem
    that occurs with it.

    >> Forking /sbin/hotplug is disabled by default, it is a broken concept,
    >> and it cannot work reliably on today's systems.
    >>
    >> Firmware is not loaded by /sbin/hotplug since many years, but by udev
    >> or whatever service handles uevents, like ueventd on android.
    >
    > Which I'm not sure why is relevant here.

    It is relevant in the sense that the firmware loader should not even
    know that a uevent *can* cause a usermodehelper exec() if it runs in
    legacy mode. The firmware loader just has no business in fiddling with
    the details of driver core legacy stuff. I don't think his warning
    makes much sense.

    Kay


    \
     
     \ /
      Last update: 2012-03-14 00:29    [W:0.035 / U:29.348 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site