lkml.org 
[lkml]   [2012]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] checkpatch: Suggest pr_<level> over printk(KERN_<LEVEL>
On Tue, 13 Mar 2012 08:05:14 -0400
"Ted Ts'o" <tytso@mit.edu> wrote:

> On Mon, Mar 12, 2012 at 11:23:03PM -0700, Joe Perches wrote:
> > Suggest the shorter pr_<level> instead of printk(KERN_<LEVEL>.
> >
> > Prefer to use pr_<level> over bare printks.
> > Prefer to use pr_warn over pr_warning.
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
>
> Is this even worth a warning? I don't think so....

mm... probably. It's not a thing I ever bother mentioning in review,
but I guess pr_foo() is a bit denser, and doing the same thing in two
different ways is always an irritant.

I'll put the patch in my tree for a while and see how irritating I find
it ;)



\
 
 \ /
  Last update: 2012-03-13 22:57    [W:0.086 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site