Messages in this thread | | | Date | Tue, 13 Mar 2012 13:47:47 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH 2/2] page_alloc: Remove argument to find_zone_movable_pfns_for_nodes |
| |
On Tue, 13 Mar 2012, Kautuk Consul wrote:
> The find_zone_movable_pfns_for_nodes() function does not utiilize > the argument to it. >
It could, though, if we made it to do so.
> Removing this argument from the function prototype as well as its > caller, i.e. free_area_init_nodes(). >
Not sure if we'd ever want it or not for other purposes, but find_zone_movable_pfns_for_nodes() could easily be made to use the passed in array rather than zone_movable_pfn in file scope directly. That seems to be why it took an argument in the first place.
> Signed-off-by: Kautuk Consul <consul.kautuk@gmail.com> > --- > mm/page_alloc.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 3171f4c..a368b9b 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -4509,7 +4509,7 @@ static unsigned long __init early_calculate_totalpages(void) > * memory. When they don't, some nodes will have more kernelcore than > * others > */ > -static void __init find_zone_movable_pfns_for_nodes(unsigned long *movable_pfn) > +static void __init find_zone_movable_pfns_for_nodes(void) > { > int i, nid; > unsigned long usable_startpfn; > @@ -4701,7 +4701,7 @@ void __init free_area_init_nodes(unsigned long *max_zone_pfn) > > /* Find the PFNs that ZONE_MOVABLE begins at in each node */ > memset(zone_movable_pfn, 0, sizeof(zone_movable_pfn)); > - find_zone_movable_pfns_for_nodes(zone_movable_pfn); > + find_zone_movable_pfns_for_nodes(); > > /* Print out the zone ranges */ > printk("Zone PFN ranges:\n");
| |