| From | Bjørn Mork <> | Subject | Re: [34-longterm 098/196] iwlagn: Support new 5000 microcode. | Date | Tue, 13 Mar 2012 17:24:42 +0100 |
| |
Paul Gortmaker <paul.gortmaker@windriver.com> writes:
> From: "Fry, Donald H" <donald.h.fry@intel.com> > > ------------------- > This is a commit scheduled for the next v2.6.34 longterm release. > If you see a problem with using this for longterm, please comment. > ------------------- > > commit 41504cce240f791f1e16561db95728c5537fbad9 upstream. > > New iwlwifi-5000 microcode requires driver support for API version 5. > > Signed-off-by: Don Fry <donald.h.fry@intel.com> > Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> > --- > drivers/net/wireless/iwlwifi/iwl-5000.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/iwlwifi/iwl-5000.c b/drivers/net/wireless/iwlwifi/iwl-5000.c > index d05fad4..dc191b8 100644 > --- a/drivers/net/wireless/iwlwifi/iwl-5000.c > +++ b/drivers/net/wireless/iwlwifi/iwl-5000.c > @@ -48,7 +48,7 @@ > #include "iwl-6000-hw.h" > > /* Highest firmware API version supported */ > -#define IWL5000_UCODE_API_MAX 2 > +#define IWL5000_UCODE_API_MAX 5 > #define IWL5150_UCODE_API_MAX 2
This looks like the patch which broke the driver in stable-2.6.32.y and was later reverted by:
commit 2a96ae707525ef00a85bf374e56f0219c07eac5a Author: Greg Kroah-Hartman <gregkh@suse.de> Date: Wed Jun 15 13:12:35 2011 -0700
Revert "iwlagn: Support new 5000 microcode."
This reverts commit 6f63415fc1b690cb50c2ad48ba6e9e6e88e271b4.
It turns out this is not what we want to have happen for the .32 and .33-longterm kernels as it does not work properly at all.
This was reported by Gentoo, Arch, and Canonical developers as causing problems for their users: https://bugs.archlinux.org/task/24302 http://bugs.gentoo.org/show_bug.cgi?id=359445 https://bugs.launchpad.net/ubuntu/+source/linux/+bug/796336
Cc: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com> Cc: Gordon Malm <gengor@gentoo.org> Cc: Don Fry <donald.h.fry@intel.com> Cc: Wey-Yi Guy <wey-yi.w.guy@intel.com> Cc: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bjørn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|