lkml.org 
[lkml]   [2012]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 3/5] Fix an access-after-free issue in function pci_stop_and_remove_bus()
    On Sun, Mar 11, 2012 at 11:48 AM, Jiang Liu <liuj97@gmail.com> wrote:
    > If pci_stop_and_remove_bus() is called to remove a pci root bus,
    > the host_bridge structure may have already been freed after returning
    > from pci_remove_bus(), so don't access the structure any more.

    pci_stop_and_remove_bus() hasn't been merged yet, so any fixes should
    be incorporated into Yinghai's patch that adds it.

    > Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
    > ---
    >  drivers/pci/remove.c |    3 ---
    >  1 files changed, 0 insertions(+), 3 deletions(-)
    >
    > diff --git a/drivers/pci/remove.c b/drivers/pci/remove.c
    > index 75b0092..25f368e 100644
    > --- a/drivers/pci/remove.c
    > +++ b/drivers/pci/remove.c
    > @@ -194,9 +194,6 @@ void pci_stop_and_remove_bus(struct pci_bus *bus)
    >
    >        pci_remove_bus(bus);
    >
    > -       if (host_bridge)
    > -               host_bridge->bus = NULL;
    > -
    >        if (pci_bridge)
    >                pci_bridge->subordinate = NULL;
    >  }
    > --
    > 1.7.5.4
    >
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-03-13 04:51    [W:6.828 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site