[lkml]   [2012]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[34-longterm 112/196] i8k: Tell gcc that *regs gets clobbered
    From: Jim Bos <>

    This is a commit scheduled for the next v2.6.34 longterm release.
    If you see a problem with using this for longterm, please comment.

    commit 6b4e81db2552bad04100e7d5ddeed7e848f53b48 upstream.

    More recent GCC caused the i8k driver to stop working, on Slackware
    compiler was upgraded from gcc-4.4.4 to gcc-4.5.1 after which it didn't
    work anymore, meaning the driver didn't load or gave total nonsensical

    As it turned out the asm(..) statement forgot to mention it modifies the
    *regs variable.

    Credits to Andi Kleen and Andreas Schwab for providing the fix.

    Signed-off-by: Jim Bos <>
    Cc: Andi Kleen <>
    Cc: Andreas Schwab <>
    Signed-off-by: Linus Torvalds <>
    Signed-off-by: Paul Gortmaker <>
    drivers/char/i8k.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/char/i8k.c b/drivers/char/i8k.c
    index fc8cf7a..828fd24 100644
    --- a/drivers/char/i8k.c
    +++ b/drivers/char/i8k.c
    @@ -141,7 +141,7 @@ static int i8k_smm(struct smm_regs *regs)
    "shrl $8,%%eax\n\t"
    "andl $1,%%eax\n"
    - :"=a"(rc)
    + :"=a"(rc), "+m" (*regs)
    : "a"(regs)
    : "%ebx", "%ecx", "%edx", "%esi", "%edi", "memory");
    @@ -166,7 +166,8 @@ static int i8k_smm(struct smm_regs *regs)
    "movl %%edx,0(%%eax)\n\t"
    "shrl $8,%%eax\n\t"
    - "andl $1,%%eax\n":"=a"(rc)
    + "andl $1,%%eax\n"
    + :"=a"(rc), "+m" (*regs)
    : "a"(regs)
    : "%ebx", "%ecx", "%edx", "%esi", "%edi", "memory");

     \ /
      Last update: 2012-03-13 01:47    [W:0.020 / U:4.960 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site