lkml.org 
[lkml]   [2012]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[34-longterm 045/196] sound: oss: midi_synth: check get_user() return value
    Date
    From: Kulikov Vasiliy <segooon@gmail.com>

    -------------------
    This is a commit scheduled for the next v2.6.34 longterm release.
    If you see a problem with using this for longterm, please comment.
    -------------------

    commit b3390ceab95601afc12213c3ec5551d3bc7b638f upstream.

    get_user() may fail, if so return -EFAULT.

    Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
    ---
    sound/oss/midi_synth.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/sound/oss/midi_synth.c b/sound/oss/midi_synth.c
    index 11685f1..2292c23 100644
    --- a/sound/oss/midi_synth.c
    +++ b/sound/oss/midi_synth.c
    @@ -519,7 +519,9 @@ midi_synth_load_patch(int dev, int format, const char __user *addr,
    {
    unsigned char data;

    - get_user(*(unsigned char *) &data, (unsigned char __user *) &((addr)[hdr_size + i]));
    + if (get_user(data,
    + (unsigned char __user *)(addr + hdr_size + i)))
    + return -EFAULT;

    eox_seen = (i > 0 && data & 0x80); /* End of sysex */

    --
    1.7.9.3


    \
     
     \ /
      Last update: 2012-03-13 01:23    [W:4.121 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site