lkml.org 
[lkml]   [2012]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/3 v2] netxen: qlogic ethernet : Fix endian bug.
From
Sure David.
I will resend it with proper comment.

Regards
Santosh

On Mon, Mar 12, 2012 at 12:18 PM, David Miller <davem@davemloft.net> wrote:
> From: santosh nayak <santoshprasadnayak@gmail.com>
> Date: Mon, 12 Mar 2012 12:08:23 +0530
>
>> From: Santosh Nayak <santoshprasadnayak@gmail.com>
>>
>> Fix endian bug.
>>
>> Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
>
> This is a very non-trivial patch, therefore the terse commit
> message and the lack of any comments in this code is unacceptable.
>
> This commit message is not only terse, it's wrong.  You're not
> fixing an endian bug, you're fixing several of them.
>
> Explain everything in your commit message.
>
>>       req.words[0] = cpu_to_le64(cmd);
>> -     req.words[1] = cpu_to_le64(ip);
>> +     memcpy(&req.words[1], &ip, sizeof(u32));
>
> Nobody is going to read that and have any idea why it's correct unless
> they happen to be able to discover the long thread you guys had this
> past week working out how to do this change correctly.
>
> Putting a comment here for the rest of us mere mortals is therefore
> absolutely required.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-03-12 07:55    [W:2.335 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site