Messages in this thread | | | Date | Sun, 11 Mar 2012 13:27:46 +0000 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH] Video : Amba: Use in_interrupt() in clcdfb_sleep(). |
| |
On Sun, Mar 11, 2012 at 06:44:25PM +0530, santosh nayak wrote: > From: Santosh Nayak <santoshprasadnayak@gmail.com> > > Instead of "in_atomic()", we can use in_interrupt() to check whether > its an interrupt context.
What are you trying to fix?
Your description is an example of a bad commit comment. It merely describes the change, which anyone can see by looking at the diff. What it totally and utterly fails to do is to describe _why_ the change is necessary or what the problem is.
So, until it does, this patch gets a definite NAK.
| |