lkml.org 
[lkml]   [2012]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/9] exec: add a global execve counter
On Sun, Mar 11, 2012 at 03:48:02PM -0700, Linus Torvalds wrote:
> On Sun, Mar 11, 2012 at 10:25 AM, Oleg Nesterov <oleg@redhat.com> wrote:
> >
> > It should be per-process, signal_struct makes more sense. Or may be
> > mm_struct.
>
> I do wonder if we shouldn't just consider the "struct mm_struct"
> pointer to *be* the unique exec ID. It's what /proc/pid/mem does, and
> it works fine, and allows us to just use a normal pointer as the
> unique ID.
>
> Just increment the mm_count for the thing, and hold a reference to it,
> and now you're all done.
Please Linus have you checked the:
[PATCH 9/9] proc: improve and clean up /proc/<pid>/mem protection

That keeping the mm struct wont work, since it will eat memory and the
OOM-killer will kill some innocent processes, and the abuse can only be
catched by the VFS.

What's your opinion on it ?


And if we do the same for all the /proc/<pid>/* files and even if you
clear the VM of the old process, some other information will still be
available, even if it is not useful, this is not consistent.
Is it ok if the code keeps different objects related to dead processes
alive ?


--
tixxdz
http://opendz.org


\
 
 \ /
  Last update: 2012-03-12 00:31    [from the cache]
©2003-2011 Jasper Spaans