lkml.org 
[lkml]   [2012]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/7] drivers/atm/eni.c: ensure arguments to request_irq and free_irq are compatible
    Date
    From: Julia Lawall <Julia.Lawall@lip6.fr>

    Convert call to request_irq so that the last argument is the same as the
    second argument of the subsequent call to free_irq. Without this
    property, free_irq does nothing.

    I have chosen to keep the call to free_irq as is, because its second
    argument is more like its first argument.

    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

    ---
    Not tested. I don't know if I have made the right choice.

    drivers/atm/eni.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c
    index 956e9ac..89e7223 100644
    --- a/drivers/atm/eni.c
    +++ b/drivers/atm/eni.c
    @@ -1800,7 +1800,8 @@ static int __devinit eni_start(struct atm_dev *dev)

    DPRINTK(">eni_start\n");
    eni_dev = ENI_DEV(dev);
    - if (request_irq(eni_dev->irq,&eni_int,IRQF_SHARED,DEV_LABEL,dev)) {
    + if (request_irq(eni_dev->irq, &eni_int, IRQF_SHARED, DEV_LABEL,
    + eni_dev)) {
    printk(KERN_ERR DEV_LABEL "(itf %d): IRQ%d is already in use\n",
    dev->number,eni_dev->irq);
    error = -EAGAIN;


    \
     
     \ /
      Last update: 2012-03-11 20:41    [W:0.029 / U:93.992 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site