lkml.org 
[lkml]   [2012]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] vt: NULL dereference in vt_do_kdsk_ioctl()
On Sat, 10 Mar 2012 11:59:23 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:

> We forgot to set the "key_map" variable here, so it's still NULL. This
> was introduced recently in 079c9534a9 "vt:tackle kbd_table".
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/tty/vt/keyboard.c b/drivers/tty/vt/keyboard.c
> index 70d0593..86dd1e3 100644
> --- a/drivers/tty/vt/keyboard.c
> +++ b/drivers/tty/vt/keyboard.c
> @@ -1863,6 +1863,7 @@ int vt_do_kdsk_ioctl(int cmd, struct kbentry __user *user_kbe, int perm,
> return -EPERM;
> }
> key_maps[s] = new_map;
> + key_map = new_map;
> key_map[0] = U(K_ALLOCATED);
> for (j = 1; j < NR_KEYS; j++)
> key_map[j] = U(K_HOLE);

Eep I thought I got all of those. Well noted

Acked-by: Alan Cox <alan@linux.intel.com>


\
 
 \ /
  Last update: 2012-03-10 13:47    [from the cache]
©2003-2011 Jasper Spaans