Messages in this thread | | | Date | Sat, 10 Mar 2012 10:38:27 +0100 | From | walter harms <> | Subject | Re: [patch] spi: release lock on error path in spi_pump_messages() |
| |
Am 10.03.2012 09:57, schrieb Dan Carpenter: > We should release the lock here and enable IRQs before returning. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c > index 5ae1e84..ab1bdce 100644 > --- a/drivers/spi/spi.c > +++ b/drivers/spi/spi.c > @@ -535,6 +535,7 @@ static void spi_pump_messages(struct kthread_work *work) > if (ret) { > dev_err(&master->dev, > "failed to unprepare transfer hardware\n"); > + spin_unlock_irqrestore(&master->queue_lock, flags); > return; > } > }
hi Dan, do you want to protect dev_err() by a spn_lock ?
re, wh
> -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > >
| |