lkml.org 
[lkml]   [2012]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [git pull] vfs fixes
On Sat, Mar 10, 2012 at 1:30 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> Jan Kara (2):
>      vfs: Fix missed wakeup in I_NEW handling

Christ. This one is too ugly to live.

I'm not pulling crap like this. It's f*^&ing stupid to take a lock,
calculate a bitqueue, and just generally be an absolute ass-hat about
things for waiting for a bit that is already set 99.999% of the time.

May I suggest just reverting that commit 250df6ed instead. It added
all these insane things for no good reason. The comment said they are
going away, but if they are just multiplying in ways like this, I
really think the damn thing needs to be reverted. Any change that
causes code like this is by definition not a good change.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-03-10 22:51    [from the cache]
©2003-2011 Jasper Spaans