lkml.org 
[lkml]   [2012]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] Allocate correct size (portably) in drivers/usb/gadget/f_midi.c::f_midi_bind()
    As the coverity checker puts it:

    "Passing argument "sizeof (midi_function) /*8*/" to function "kcalloc"
    and then casting the return value to "struct usb_descriptor_header **"
    is suspicious. ... In this particular case sizeof(struct
    usb_descriptor_header **) happens to be equal to sizeof(struct
    usb_descriptor_header *), but this is not a portable assumption."

    I believe we really do intend to use 'sizeof(*midi_function)' here, so
    this patch makes that change.

    Signed-off-by: Jesper Juhl <jj@chaosbits.net>
    ---
    drivers/usb/gadget/f_midi.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/usb/gadget/f_midi.c b/drivers/usb/gadget/f_midi.c
    index 3797b3d..2f7e8f2 100644
    --- a/drivers/usb/gadget/f_midi.c
    +++ b/drivers/usb/gadget/f_midi.c
    @@ -780,7 +780,7 @@ f_midi_bind(struct usb_configuration *c, struct usb_function *f)
    midi->out_ep->driver_data = cdev; /* claim */

    /* allocate temporary function list */
    - midi_function = kcalloc((MAX_PORTS * 4) + 9, sizeof(midi_function),
    + midi_function = kcalloc((MAX_PORTS * 4) + 9, sizeof(*midi_function),
    GFP_KERNEL);
    if (!midi_function) {
    status = -ENOMEM;
    --
    1.7.9.2

    --
    Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
    Don't top-post http://www.catb.org/jargon/html/T/top-post.html
    Plain text mails only, please.



    \
     
     \ /
      Last update: 2012-03-01 23:05    [W:0.020 / U:31.464 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site