lkml.org 
[lkml]   [2012]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 34/34] PM / Sleep: Fix read_unlock_usermodehelper() call.
    2.6.32-longterm review patch.  If anyone has any objections, please let me know.

    ------------------


    From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>

    [ Upstream commit e4c89a508f4385a0cd8681c2749a2cd2fa476e40 ]

    Commit b298d289
    "PM / Sleep: Fix freezer failures due to racy usermodehelper_is_disabled()"
    added read_unlock_usermodehelper() but read_unlock_usermodehelper() is called
    without read_lock_usermodehelper() when kmalloc() failed.

    Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
    Acked-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
    Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
    Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---

    drivers/base/firmware_class.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/drivers/base/firmware_class.c
    +++ b/drivers/base/firmware_class.c
    @@ -493,8 +493,7 @@ _request_firmware(const struct firmware
    if (!firmware) {
    dev_err(device, "%s: kmalloc(struct firmware) failed\n",
    __func__);
    - retval = -ENOMEM;
    - goto out;
    + return -ENOMEM;
    }

    for (builtin = __start_builtin_fw; builtin != __end_builtin_fw;



    \
     
     \ /
      Last update: 2012-03-01 22:55    [W:0.022 / U:88.796 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site