[lkml]   [2012]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC PATCH 00/22] loop: Issue O_DIRECT aio with pages
Christoph Hellwig <> writes:

> On Tue, Feb 28, 2012 at 10:14:34AM -0500, Zach Brown wrote:
>> Yeah, that's reasonable. Perhaps obviously, we started with new entry
>> points to minimize the amount of churn we'd have to go through to test
>> the change in behaviour.
>> It's going to be messy to try and abstract away the pinning and dirtying
>> of the iter regions from direct IO through the iter interface, but maybe
>> not horribly so.
> I don't really care to much about the implementation inside fs/direct-io.c
> (at least for now - once I see it I might still scream "bloody
> murder!").
> The point is to pass the iov_iter all the way down to a common entry
> point in fs/direct-io.c, so that the filesystems don't have to care
> for that difference.

I started reviewing, but I think I'll hold off until the next posting.
Dave, what was the original subject of the thread from Zach back in '09?
That spinics link isn't working for me anymore, and I'd like to go back
over my review comments from back then.


 \ /
  Last update: 2012-03-01 21:35    [W:0.074 / U:8.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site