lkml.org 
[lkml]   [2012]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/9] writeback: introduce the pageout work
On Thu, 1 Mar 2012 12:04:04 +0100
Jan Kara <jack@suse.cz> wrote:

> > iirc, the way I "grabbed" the page was to actually lock it, with
> > [try_]_lock_page(). And unlock it again way over within the writeback
> > thread. I forget why I did it this way, rather than get_page() or
> > whatever. Locking the page is a good way of preventing anyone else
> > from futzing with it. It also pins the inode, which perhaps meant that
> > with careful management, I could avoid the igrab()/iput() horrors
> > discussed above.
>
> I think using get_page() might be a good way to go.

get_page() doesn't pin the inode - truncate() will still detach it
from the address_space().


\
 
 \ /
  Last update: 2012-03-01 20:45    [from the cache]
©2003-2011 Jasper Spaans