lkml.org 
[lkml]   [2012]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 01/11] vfs: extend vfs_removexattr locking
    Date
    This patch takes the i_mutex lock before security_inode_removexattr(),
    instead of after, in preparation of calling ima_inode_removexattr().

    Signed-off-by: Mimi Zohar <zohar@us.ibm.com>
    Signed-off-by: Dmitry Kasatkin <dmitry.kasatkin@nokia.com>
    ---
    fs/xattr.c | 6 ++++--
    1 files changed, 4 insertions(+), 2 deletions(-)

    diff --git a/fs/xattr.c b/fs/xattr.c
    index 82f4337..6112c92 100644
    --- a/fs/xattr.c
    +++ b/fs/xattr.c
    @@ -294,11 +294,13 @@ vfs_removexattr(struct dentry *dentry, const char *name)
    if (error)
    return error;

    + mutex_lock(&inode->i_mutex);
    error = security_inode_removexattr(dentry, name);
    - if (error)
    + if (error) {
    + mutex_unlock(&inode->i_mutex);
    return error;
    + }

    - mutex_lock(&inode->i_mutex);
    error = inode->i_op->removexattr(dentry, name);
    mutex_unlock(&inode->i_mutex);

    --
    1.7.6.5


    \
     
     \ /
      Last update: 2012-03-01 20:17    [W:0.021 / U:4.032 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site