[lkml]   [2012]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH] exec: abort core dump piping only due to a fatal signal
    This patch makes wait_for_dump_helpers() not to abort piping the core
    dump data when the crashing process has received any but a fatal signal
    (SIGKILL). The rationale is that a crashing process may still receive
    uninteresting signals such as SIGCHLD when its core dump data is being
    redirected to a helper application. While it's necessary to allow
    terminating the core dump piping via SIGKILL, it's practically more
    useful for the purpose of debugging and crash reporting if the core dump
    piping is not aborted due to other non-fatal signals.


    Signed-off-by: Ben Chan <>
    Cc: Alexander Viro <>
    Cc: Andrew Morton <>
    Cc: Oleg Nesterov <>
    fs/exec.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/fs/exec.c b/fs/exec.c
    index 92ce83a..a614203 100644
    --- a/fs/exec.c
    +++ b/fs/exec.c
    @@ -2031,7 +2031,7 @@ static void wait_for_dump_helpers(struct file *file)

    - while ((pipe->readers > 1) && (!signal_pending(current))) {
    + while ((pipe->readers > 1) && (!fatal_signal_pending(current))) {
    kill_fasync(&pipe->fasync_readers, SIGIO, POLL_IN);

     \ /
      Last update: 2012-03-01 19:27    [W:0.019 / U:12.756 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site