Messages in this thread | | | Date | Thu, 1 Mar 2012 15:53:29 +0530 | Subject | Re: [PATCH 2/3] netfilter: potential null derefence. | From | santosh prasad nayak <> |
| |
Hi Pablo,
Please look at the last line of my patch. I have added a new label "out"
regards santosh
On Thu, Mar 1, 2012 at 3:51 PM, Pablo Neira Ayuso <pablo@netfilter.org> wrote: > On Thu, Mar 01, 2012 at 02:47:14PM +0530, santosh nayak wrote: >> From: Santosh Nayak <santoshprasadnayak@gmail.com> >> >> I am getting following error. >> " net/bridge/netfilter/ebtables.c:269 ebt_do_table() >> error: potential null derefence 'cs'" >> >> i = cs[sp].n; // If cs == Null then this will cause problem. >> >> Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com> >> --- >> net/bridge/netfilter/ebtables.c | 5 ++++- >> 1 files changed, 4 insertions(+), 1 deletions(-) >> >> diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c >> index f3fcbd9..9c0f177 100644 >> --- a/net/bridge/netfilter/ebtables.c >> +++ b/net/bridge/netfilter/ebtables.c >> @@ -209,8 +209,10 @@ unsigned int ebt_do_table (unsigned int hook, struct sk_buff *skb, >> smp_processor_id()); >> if (private->chainstack) >> cs = private->chainstack[smp_processor_id()]; >> - else >> + else { >> cs = NULL; >> + goto out; > > There is no "out" label in ebt_do_table !! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |