lkml.org 
[lkml]   [2012]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v10 3.3-rc2 1/9] uprobes: Install and remove breakpoints.
> >>
> >
> > I am confused by why we need to call insn_get_length(insn) before
> > checking insn->rex_prefix.nbytes? Is it needed.
>
> Ah, certainly, no, if the insn is already decoded.

Okay,

> >
> > uprobe->arch_info.rip_rela_target_address = 0x0;
> > if (!insn_rip_relative(insn))
> > return;
>
> Here, I think it is better to add a comment that
> insn_rip_relative() decodes until modrm. :)

Will do.

>
> > return;
> > }
>
> Confirmed, this looks good to me ;)
>
> Thanks!

Okay, Thanks for confirming,

Do you have a handy instruction whose REX.B is set that I could use to test.

--
Thanks and Regards
Srikar



\
 
 \ /
  Last update: 2012-02-09 09:43    [W:0.067 / U:2.696 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site