Messages in this thread | | | Date | Thu, 9 Feb 2012 17:36:53 -0500 | From | Paul Gortmaker <> | Subject | Re: 8250 move broke the build on sparc |
| |
On 12-02-09 04:30 PM, David Miller wrote: > > Commit 9bef3d4197379a995fa80f81950bbbf8d32e9e8b ("serial: group all > the 8250 related code together") broke the build on sparc. > > You really can't move 8250.c around without adjusting the "" includes > such as the one for "suncore.h".
Understood. As I mentioned earlier[1], I'd done sparc builds, but completely missed the fact that sparc didn't have 8250 enabled by default. Good intentions, but bad execution. Sorry about the fallout.
> > Simply changing "suncore.h" to "../suncore.h" fixes things, but that's > pretty ugly if you ask me.
It only uses suncore.h for sunserial_register_minors (and unreg). Would you like it better if I killed all ifdefs and the include and used an incantation of weak instead? Might be cleaner....
P.
[1] https://lkml.org/lkml/2012/2/3/355
| |