lkml.org 
[lkml]   [2012]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 8250 move broke the build on sparc
On 12-02-09 04:30 PM, David Miller wrote:
>
> Commit 9bef3d4197379a995fa80f81950bbbf8d32e9e8b ("serial: group all
> the 8250 related code together") broke the build on sparc.
>
> You really can't move 8250.c around without adjusting the "" includes
> such as the one for "suncore.h".

Understood. As I mentioned earlier[1], I'd done sparc builds, but
completely missed the fact that sparc didn't have 8250 enabled
by default. Good intentions, but bad execution. Sorry about
the fallout.

>
> Simply changing "suncore.h" to "../suncore.h" fixes things, but that's
> pretty ugly if you ask me.

It only uses suncore.h for sunserial_register_minors (and unreg).
Would you like it better if I killed all ifdefs and the include
and used an incantation of weak instead? Might be cleaner....

P.

[1] https://lkml.org/lkml/2012/2/3/355


\
 
 \ /
  Last update: 2012-02-09 23:39    [W:0.058 / U:0.960 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site