[lkml]   [2012]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/2] Staging; Don't leak 'pstAddIndication' in CmHost.c::StoreCmControlResponseMessage()
On Tue, Jan 24, 2012 at 11:47:27PM +0100, Jesper Juhl wrote:
> We allocate memory for 'pstAddIndication' with kmalloc() in
> drivers/staging/bcm/CmHost.c::StoreCmControlResponseMessage() and then
> neglect to free it on a number of exit paths from that function.
> This could probably be resolved cleaner/nicer, but this file needs a
> serious overhaul in any case, so I opted for just fixing the problem
> as directly as I could and then we can clean it up generally
> later... This at least makes it stop bleeding..
> Signed-off-by: Jesper Juhl <>
> ---
> drivers/staging/bcm/CmHost.c | 27 ++++++++++++++++++++-------
> 1 files changed, 20 insertions(+), 7 deletions(-)

This patch no longer applies, care to redo it against the latest
linux-next tree?


greg k-h

 \ /
  Last update: 2012-02-09 18:55    [W:0.065 / U:2.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site