lkml.org 
[lkml]   [2012]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] perf-tool: Don't process samples with no valid machine object
On Thu, Feb 09, 2012 at 02:34:41PM -0200, Arnaldo Carvalho de Melo wrote:
> Em Thu, Feb 09, 2012 at 05:07:38PM +0100, Joerg Roedel escreveu:
> > - if (event->header.type == PERF_RECORD_SAMPLE) {
> > + if (event->header.type == PERF_RECORD_SAMPLE && machine != NULL) {
>
> Shouldn't we warn the user, even if just once, on the status (last line
> on the screen) line?

Probably yes, what would be a good message? I guess something like

"no machine object for sample"

is not helpful to the user. Maybe something like

"Unresolvable sample(s) recorded"?

Or something completly different?


Joerg

--
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632



\
 
 \ /
  Last update: 2012-02-09 18:17    [W:0.066 / U:4.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site