Messages in this thread | | | Subject | Re: [PATCH 1/2] regulator: Don't add the function name to pr_fmt | From | Liam Girdwood <> | Date | Thu, 09 Feb 2012 15:23:49 +0000 |
| |
On Thu, 2012-02-09 at 13:42 +0000, Mark Brown wrote: > Liam pointed out via IM that since we now use the pure function name for > all regulator logging a lot of the messages such as those logging the > constraints are getting a bit noisy due to the implementation detail > that is the function name: > > print_constraints: VDDARM: 1000 <--> 1300 mV at 1300 mV at 0 mA > > In discussion it seemed like the best thing was to just drop the pr_fmt > and clarify individual log messages where there is an issue otherwise > we get into silly things like renaming the functions to suit the logging. > > This is mostly an issue as we have a moderate amount of non-error logging > in the boot sequence to aid debug if something goes wrong since regulator > misconfiguration can kill the system pretty quickly. > > Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Both
Acked-by: Liam Girdwood <lrg@ti.com>
| |