Messages in this thread | | | From | Oliver Neukum <> | Subject | Re: [PATCH 37/50] usbnet: set addr_assign_type if random_ether_addr() used | Date | Thu, 9 Feb 2012 15:55:14 +0100 |
| |
Am Donnerstag, 9. Februar 2012, 07:57:42 schrieb Bjørn Mork: > > Don't you set the flag too early here? By that time we don't know > > whether the device provides a real MAC, do we? > > Maybe it makes sense to set it here anyway since usbnet provides this > default random address, and let the minidrivers which set a real mac > also clear the flag? But in that case the patch need to clear the flag > everywhere a minidriver currently updates the address. >
Doable, but where is the benefit? It seems better to me to make an effort to guess as well as possible in the common code.
Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |