lkml.org 
[lkml]   [2012]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf tools: Allow multiple threads or processes in record, stat, top
Em Thu, Feb 09, 2012 at 12:34:49PM -0200, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Feb 09, 2012 at 08:37:27AM +0100, Ingo Molnar escreveu:
> >
> > * David Ahern <dsahern@gmail.com> wrote:
> >
> > > > I was trying to remove ctype.h, you might use util.h here.
> > >
> > > Right, knew that. But, in this case I am adding a call to
> > > isdigit which means a direct dependency on ctype.h. I would
> > > prefer a direct relationship versus an indirect via util.h
> >
> > Please just remove ctype.h *altogether* from perf, it's just an
> > insane header.
> >
> > Have a look at how Git solves these types of problems, it
> > defines sane string functions in git-compat-util.h:
>
> Yeah, these are in util.h, that doesn't includes ctype.h
>
> I'm fixing this up and also that s/UUID/UID/g Kim pointed out,
> then testing if the python binding still is ok with these changes.

[root@aninha linux]# tools/perf/python/twatch.py
Traceback (most recent call last):
File "tools/perf/python/twatch.py", line 16, in <module>
import perf
ImportError: /home/acme/git/build/perf/python/perf.so: undefined symbol:
ui__error
[root@aninha linux]#

it breaks, I'll check an alternative way to report problems without
calling ui__ methods from thread_map.

- Arnaldo


\
 
 \ /
  Last update: 2012-02-09 15:47    [W:0.069 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site