lkml.org 
[lkml]   [2012]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V1] regmap: add bulk_write() for non-volatile register set
On Thu, Feb 09, 2012 at 05:42:11PM +0530, Laxman Dewangan wrote:

> + if (vol || map->cache_type == REGCACHE_NONE) {
> + ret = _regmap_raw_write(map, reg, val, val_bytes * val_count);

You still need to do the byte swap here.

> + } else {
> + for (i = 0; i < val_count; i++) {
> + memcpy(map->work_buf, val + (i * val_bytes), val_bytes);
> + ival = map->format.parse_val(map->work_buf);

They're currently symmetric but really this should use format_val().
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-02-09 13:19    [W:0.063 / U:0.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site