lkml.org 
[lkml]   [2012]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V1 1/2] mfd: tps65910: use regmap for device register access.
On Thursday 09 February 2012 05:33 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Thu, Feb 09, 2012 at 05:29:38PM +0530, Laxman Dewangan wrote:
>
>> I am working on mfd/tps65910.c and function is:
>> static int tps65910_i2c_write(struct tps65910 *tps65910, u8 reg,
>> int bytes, void *src)
>> All your feedback will help me to improve my next two mfd/pmic
>> drivers which I am planning to upstream...
> Yeah, I know that's the i2c_write() function but all the callers I
> noticed were calling it with bytes set to 1.
>
Yes, currently all callers are calling with 1 byte but when we will add
rtc (which is not there currently), at that time, it may call multibyte
read/write.
The interface is such that it can support multi-byte transfer. And when
using for single byte transfer (currently) and if it is cached,
regmap_raw_write() is creating warnings and that's why I broken transfer
in multi-transfer in tps65910.c which was not a good idea..


> * Unknown Key
> * 0x6E30FDDD



\
 
 \ /
  Last update: 2012-02-09 13:13    [W:0.047 / U:0.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site