lkml.org 
[lkml]   [2012]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 20/50] smsc911x: use dev_hw_addr_random() instead of random_ether_addr()
On Wed, Feb 08, 2012 at 10:10:27PM +0100, Danny Kukawka wrote:

> + if (dev->addr_assign_type & NET_ADDR_RANDOM)
> + dev->addr_assign_type ^= NET_ADDR_RANDOM;

It would be clearer to just write

dev->addr_assign_type &= ~NET_ADDR_RANDOM;

to clear the bit - the ^ takes more thinking.


\
 
 \ /
  Last update: 2012-02-09 12:31    [W:2.208 / U:1.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site