lkml.org 
[lkml]   [2012]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] selftests: Launch individual selftests from the main Makefile
On Wed, Feb 08, 2012 at 03:20:22PM -0800, Andrew Morton wrote:
> On Wed, 8 Feb 2012 04:40:59 +0100
> Frederic Weisbecker <fweisbec@gmail.com> wrote:
>
> > Drop the run_tests script and launch the selftests by calling
> > "make run_tests" from the selftests top directory instead. This
> > delegates to the Makefile on each selftest directory where it
> > is decided how to launch the local test.
> >
> > This drops the need to add each selftest directory on the
> > now removed "run_tests" top script.
>
> Looks good.
>
> I did
>
> cd tools/testing/selftests
> make run_tests
>
> and it didn't work. This?
>
>
>
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: selftests/Makefile: make `run_tests' depend on `all'
>
> So a "make run_tests" will build the tests before trying to run them.
>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> tools/testing/selftests/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN tools/testing/selftests/Makefile~a tools/testing/selftests/Makefile
> --- a/tools/testing/selftests/Makefile~a
> +++ a/tools/testing/selftests/Makefile
> @@ -5,7 +5,7 @@ all:
> make -C $$TARGET; \
> done;
>
> -run_tests:
> +run_tests: all
> for TARGET in $(TARGETS); do \
> make -C $$TARGET run_tests; \
> done;

Yeah that's good. Thanks!


\
 
 \ /
  Last update: 2012-02-09 01:01    [from the cache]
©2003-2011 Jasper Spaans